]> git.karo-electronics.de Git - karo-tx-linux.git/commit
bnx2x: prevent crash when accessing PTP with interface down
authorMichal Schmidt <mschmidt@redhat.com>
Fri, 3 Mar 2017 16:08:28 +0000 (17:08 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 7 Mar 2017 21:47:14 +0000 (13:47 -0800)
commit466e8bf10ac104d96e1ea813e8126e11cb72ea20
tree20b9e7dc51f65385a9000ade93bde03cd20c80a2
parent239870f2a0ebf75cc8f6d987dc528c5243f93d69
bnx2x: prevent crash when accessing PTP with interface down

It is possible to crash the kernel by accessing a PTP device while its
associated bnx2x interface is down. Before the interface is brought up,
the timecounter is not initialized, so accessing it results in NULL
dereference.

Fix it by checking if the interface is up.

Use -ENETDOWN as the error code when the interface is down.
 -EFAULT in bnx2x_ptp_adjfreq() did not seem right.

Tested using phc_ctl get/set/adj/freq commands.

Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c