]> git.karo-electronics.de Git - karo-tx-linux.git/commit
drm/i915: dsi: fix pipe-off timeout due to port vs. pipe disable ordering
authorImre Deak <imre.deak@intel.com>
Tue, 27 May 2014 16:00:09 +0000 (19:00 +0300)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 27 May 2014 17:16:23 +0000 (19:16 +0200)
commit4768d5c5882e2745eccc05151d143f0db0711ffe
tree4ab40ba3f73210c5f8230460146091fd8942e3b8
parent7d77dc5c8948de82206348499cabf693c33abf8b
drm/i915: dsi: fix pipe-off timeout due to port vs. pipe disable ordering

If we disable first the port (by disabling DPI) and only then the
display pipe the pipe-off flag will never be set, possibly leading to a
hanged pipe state at the next modeset-enable.

Note that according to the VLV2 display cluster HAS, we should disable
the port before the pipe. This doesn't seem to match reality based on
the above and it's also asymmetric with the enabling sequence, where we
first enable the port and then the pipe.

v2:
- send the panel shutdown command before stopping the pipe, since this
  is the recommended sequence (Shobhit)

Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Shobhit Kumar <shobhit.kumar@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_dsi.c