]> git.karo-electronics.de Git - linux-beck.git/commit
bridge: Don't include NDA_VLAN for FDB entries with vid 0
authorToshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Wed, 30 Jul 2014 04:31:51 +0000 (13:31 +0900)
committerDavid S. Miller <davem@davemloft.net>
Thu, 31 Jul 2014 19:18:44 +0000 (12:18 -0700)
commit47fab41ab51a18a2e5fc4ec63f16b4c6702809b6
tree669e5b6dbbab7092176c3e2759f0712d3fe4d9d5
parent7afcaec4969652e177cf0b247a1530ac927a20f8
bridge: Don't include NDA_VLAN for FDB entries with vid 0

An FDB entry with vlan_id 0 doesn't mean it is used in vlan 0, but used when
vlan_filtering is disabled.

There is inconsistency around NDA_VLAN whose payload is 0 - even if we add
an entry by RTM_NEWNEIGH without any NDA_VLAN, and even though adding an
entry with NDA_VLAN 0 is prohibited, we get an entry with NDA_VLAN 0 by
RTM_GETNEIGH.

Dumping an FDB entry with vlan_id 0 shouldn't include NDA_VLAN.

Signed-off-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/bridge/br_fdb.c