]> git.karo-electronics.de Git - linux-beck.git/commit
staging: rtl8723au: change parameter type in rtl8723a_set_rssi_cmd declaration
authorAnatoly Stepanov <drivengroove@gmail.com>
Thu, 17 Dec 2015 13:47:36 +0000 (16:47 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 8 Feb 2016 03:45:30 +0000 (19:45 -0800)
commit485b099ad8c0a9ad5c856bef60017faa5178e744
tree15acf947c5f4e947011341b768e346b792233fce
parent3d7a84776a87bfcf9f7ed5de5e8ac71d3ca8a49b
staging: rtl8723au: change parameter type in rtl8723a_set_rssi_cmd declaration

Previosly the function had the following prototype:
int rtl8723a_set_rssi_cmd(struct rtw_adapter *padapter, u8 *param)

My suggestion here is to modify the prototype this way:
int rtl8723a_set_rssi_cmd(struct rtw_adapter *padapter, u32 param)

We can do this based on the following considerations:
1. rtl8723a_set_rssi_cmd is used only with 32-bit "param" values
2. There's no point in using "u8 *param" until we pass param length
3. As we just read "param", it's ok to pass it by value

Signed-off-by: Anatoly Stepanov <drivengroove@gmail.com>
Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723au/hal/odm.c
drivers/staging/rtl8723au/hal/rtl8723a_cmd.c
drivers/staging/rtl8723au/include/rtl8723a_cmd.h