]> git.karo-electronics.de Git - karo-tx-linux.git/commit
net: clear heap allocations for privileged ethtool actions
authorKees Cook <kees.cook@canonical.com>
Mon, 11 Oct 2010 19:23:25 +0000 (12:23 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 21 Mar 2011 19:43:20 +0000 (12:43 -0700)
commit487a1f7338ff740bde0d15f97c44b7b8029cc9c7
tree2752541fccc815c1bb46bdeb999906c351e118f6
parent217e4b61e6b5e14f950b5353ba261d9cd8142186
net: clear heap allocations for privileged ethtool actions

[ Upstream commit b00916b189d13a615ff05c9242201135992fcda3 ]

Several other ethtool functions leave heap uncleared (potentially) by
drivers. Some interfaces appear safe (eeprom, etc), in that the sizes
are well controlled. In some situations (e.g. unchecked error conditions),
the heap will remain unchanged in areas before copying back to userspace.
Note that these are less of an issue since these all require CAP_NET_ADMIN.

Cc: stable@kernel.org
Signed-off-by: Kees Cook <kees.cook@canonical.com>
Acked-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/core/ethtool.c