]> git.karo-electronics.de Git - karo-tx-linux.git/commit
include/log2.h: fix rounddown_pow_of_two(1)
authorAndrei Warkentin <andreiw@vmware.com>
Thu, 8 Dec 2011 04:41:56 +0000 (15:41 +1100)
committerStephen Rothwell <sfr@canb.auug.org.au>
Fri, 9 Dec 2011 04:52:41 +0000 (15:52 +1100)
commit48eaa157e415b63ca0f6169b529b04a16d620d39
tree198ffe412f5b1ca094d9ea0539b025c22ae26078
parent0bd21c0ac563648910aec89f2e91bf1531fc2a7b
include/log2.h: fix rounddown_pow_of_two(1)

1 is a power of two, therefore rounddown_pow_of_two(1) should return 1.
It does in case the argument is a variable but in case it's a constant it
behaves wrong and returns 0.  Probably nobody ever did it so this was
never noticed, however net/drivers/vmxnet3 with latest GCC does and breaks
on unicpu systems.

This is similar to Rolf's patch to roundup_pow_of_two(1).

Cc: Rolf Eike Beer <eike-kernel@sf-tec.de>
Reviewed-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Andrei Warkentin <andreiw@vmware.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
include/linux/log2.h