]> git.karo-electronics.de Git - karo-tx-linux.git/commit
i40e: properly cleanup on allocation failure in i40e_sync_vsi_filters
authorJacob Keller <jacob.e.keller@intel.com>
Wed, 5 Oct 2016 16:30:38 +0000 (09:30 -0700)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Mon, 31 Oct 2016 21:26:40 +0000 (14:26 -0700)
commit4a2ce27bb5f291c38d8e49ef16899828289e4d3d
tree07a332e6ed3a2686b179bfbc5eed6f59401d9fbc
parent278e7d0b9d6864a9749b9473a273892aa1528621
i40e: properly cleanup on allocation failure in i40e_sync_vsi_filters

Currently, we fail to correctly restore filters on the temporary add
list when we fail to allocate memory either for deletion or addition.
Replace calls to "goto out;" with calls to a new location that correctly
handles memory allocation failures.

Note that it is safe for us to call i40e_undo_filter_entries on the
tmp_del_list even after we've deleted filters because at this point it
will be empty, so we don't need to separate the logic for add and
delete failure.

Change-Id: Iee107fd219c6e03e2fd9645c2debf8e8384a8521
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/i40e/i40e_main.c