]> git.karo-electronics.de Git - linux-beck.git/commit
ps3-vuart: don't use PREPARE_WORK
authorTejun Heo <tj@kernel.org>
Fri, 7 Mar 2014 15:24:48 +0000 (10:24 -0500)
committerTejun Heo <tj@kernel.org>
Fri, 7 Mar 2014 15:24:48 +0000 (10:24 -0500)
commit4a8bb7f54860a3241b177bdeb06bb880151a23dc
tree98f9da64a3587340a1dd0323abb53bdd508abdfc
parentd82fead4639ab657d70f71b2bfefcd387a7c2a4c
ps3-vuart: don't use PREPARE_WORK

PREPARE_[DELAYED_]WORK() are being phased out.  They have few users
and a nasty surprise in terms of reentrancy guarantee as workqueue
considers work items to be different if they don't have the same work
function.

ps3_vuart wasn't overriding the work item with multiple work functions
but was using NULL for INIT_WORK() and then single PREPARE_WORK() to
set the work function.  We can simply invoke INIT_WORK() with the work
function and remove the PREPARE_WORK() usage.

It would probably be best to route this with other related updates
through the workqueue tree.

Geoff: Tested on ps3 (DECR-1400).

Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: Geoff Levand <geoff@infradead.org>
Cc: linuxppc-dev@lists.ozlabs.org
Cc: cbe-oss-dev@lists.ozlabs.org
drivers/ps3/ps3-vuart.c