]> git.karo-electronics.de Git - linux-beck.git/commit
drivers/ata/sata_rcar.c: simplify use of devm_ioremap_resource
authorJulia Lawall <Julia.Lawall@lip6.fr>
Wed, 14 Aug 2013 09:11:31 +0000 (11:11 +0200)
committerTejun Heo <tj@kernel.org>
Wed, 14 Aug 2013 13:31:36 +0000 (09:31 -0400)
commit4a9b7f9f2704405c05b213f8f51e9f7f1fe02d1a
treefe582e9da382bc4fe1d398232f0285670e723778
parent404eafe137f858b21e2b57e3f980057ec8919fea
drivers/ata/sata_rcar.c: simplify use of devm_ioremap_resource

Remove unneeded error handling on the result of a call to
platform_get_resource when the value is passed to devm_ioremap_resource.

Move the call to platform_get_resource adjacent to the call to
devm_ioremap_resource to make the connection between them more clear.

A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression pdev,res,n,e,e1;
expression ret != 0;
identifier l;
@@

- res = platform_get_resource(pdev, IORESOURCE_MEM, n);
  ... when != res
- if (res == NULL) { ... \(goto l;\|return ret;\) }
  ... when != res
+ res = platform_get_resource(pdev, IORESOURCE_MEM, n);
  e = devm_ioremap_resource(e1, res);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Tejun Heo <tj@kernel.org>
drivers/ata/sata_rcar.c