]> git.karo-electronics.de Git - linux-beck.git/commit
ext4: FIBMAP ioctl causes BUG_ON due to handle EXT_MAX_BLOCKS
authorKazuya Mio <k-mio@sx.jp.nec.com>
Mon, 7 Apr 2014 14:53:28 +0000 (10:53 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Mon, 7 Apr 2014 14:53:28 +0000 (10:53 -0400)
commit4adb6ab3e0fa71363a5ef229544b2d17de6600d7
tree3c9e190381fca754d300925d2f817ca9de53d4ad
parent666525dfbdca09bbd4848ac711e4a4dbd6921325
ext4: FIBMAP ioctl causes BUG_ON due to handle EXT_MAX_BLOCKS

When we try to get 2^32-1 block of the file which has the extent
(ee_block=2^32-2, ee_len=1) with FIBMAP ioctl, it causes BUG_ON
in ext4_ext_put_gap_in_cache().

To avoid the problem, ext4_map_blocks() needs to check the file logical block
number. ext4_ext_put_gap_in_cache() called via ext4_map_blocks() cannot
handle 2^32-1 because the maximum file logical block number is 2^32-2.

Note that ext4_ind_map_blocks() returns -EIO when the block number is invalid.
So ext4_map_blocks() should also return the same errno.

Signed-off-by: Kazuya Mio <k-mio@sx.jp.nec.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: stable@vger.kernel.org
fs/ext4/inode.c