]> git.karo-electronics.de Git - karo-tx-linux.git/commit
drm/i915: Fix pipe config warnings when dealing with LVDS fixed mode
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Mon, 2 Sep 2013 18:13:39 +0000 (21:13 +0300)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 3 Sep 2013 17:18:00 +0000 (19:18 +0200)
commit4c6df4b4ca1b26f4532d403b544f649a1c801fd1
treea67ca2b31b1db58cccee9024110795fb4b62be7e
parentd2933a5b8f8f11cbdf9d2e44f0c7c7abeeb64e6b
drm/i915: Fix pipe config warnings when dealing with LVDS fixed mode

intel_fixed_panel_mode() overwrote the adjusted_mode with the fixed mode
only partially. Notably it forgot to copy over the sync flags. The LVDS code however programmed the hardware with the sync flags from fixed mode, and then later the pipe config comparison obviously failed as we
filled out the adjusted_mode in get_config from the real registers.

Just call drm_mode_copy() in intel_fixed_panel_mode() to copy over the
whole thing, and then just use adjusted_mode in the LVDS code to figure
out which sync settings the hardware needs.

Also constify the fixed_mode argument to intel_fixed_panel_mode().

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_drv.h
drivers/gpu/drm/i915/intel_lvds.c
drivers/gpu/drm/i915/intel_panel.c