]> git.karo-electronics.de Git - karo-tx-linux.git/commit
RDMA/ocrdma: Fix warnings about uninitialized variables
authorRoland Dreier <roland@purestorage.com>
Mon, 16 Apr 2012 18:32:17 +0000 (11:32 -0700)
committerRoland Dreier <roland@purestorage.com>
Mon, 16 Apr 2012 18:32:17 +0000 (11:32 -0700)
commit4ce4f10e8e0d71be02fe1934fc001ca8ca58a4f0
treea7bcae8708da9df490830fe59614c4d7ca9aa10a
parentf725f6fd1dbc037256036d09af074bf4775cc3d7
RDMA/ocrdma: Fix warnings about uninitialized variables

First, fix

    drivers/infiniband/hw/ocrdma/ocrdma_verbs.c: In function 'ocrdma_alloc_pd':
    drivers/infiniband/hw/ocrdma/ocrdma_verbs.c:371:17: warning: 'dpp_page_addr' may be used uninitialized in this function [-Wuninitialized]
    drivers/infiniband/hw/ocrdma/ocrdma_verbs.c:337:6: note: 'dpp_page_addr' was declared here

which seems that it may border on a bug (the call to ocrdma_del_mmap()
might conceivably do bad things if pd->dpp_enabled is not set and
dpp_page_addr ends up with just the wrong value).

Also take care of:

    drivers/infiniband/hw/ocrdma/ocrdma_hw.c: In function 'ocrdma_init_hw':
    drivers/infiniband/hw/ocrdma/ocrdma_hw.c:2587:5: warning: 'status' may be used uninitialized in this function [-Wuninitialized]
    drivers/infiniband/hw/ocrdma/ocrdma_hw.c:2549:17: note: 'status' was declared here

which is only real if num_eq == 0, which should be impossible.

Signed-off-by: Roland Dreier <roland@purestorage.com>
drivers/infiniband/hw/ocrdma/ocrdma_hw.c
drivers/infiniband/hw/ocrdma/ocrdma_verbs.c