]> git.karo-electronics.de Git - linux-beck.git/commit
PCI: imx6: Move link up check into imx6_pcie_wait_for_link()
authorLucas Stach <l.stach@pengutronix.de>
Mon, 25 Jan 2016 22:50:02 +0000 (16:50 -0600)
committerBjorn Helgaas <bhelgaas@google.com>
Mon, 25 Jan 2016 22:50:02 +0000 (16:50 -0600)
commit4d107d3b5a686b5834e533a00b73bf7b1cf59df7
treedc851256d8c34ef193b7fa5f75d7c7e0b7b7da9e
parenta77c5422d7586003643377afdb9915e76d07d21c
PCI: imx6: Move link up check into imx6_pcie_wait_for_link()

imx6_pcie_link_up() previously used usleep_range() to wait for the link to
come up.  Since it may be called while holding the config spinlock, the
sleep causes a "BUG: scheduling while atomic" error.

Instead of waiting for the link to come up in imx6_pcie_link_up(), do the
waiting in imx6_pcie_wait_for_link(), where we're not holding a lock and
sleeping is allowed.

[bhelgaas: changelog, references to bugzilla and f95d3ae77191]
Link: https://bugzilla.kernel.org/show_bug.cgi?id=100031
Fixes: f95d3ae77191 ("PCI: imx6: Wait for retraining")
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
drivers/pci/host/pci-imx6.c