]> git.karo-electronics.de Git - karo-tx-linux.git/commit
drm/i915: Fix 32b overflow check in gen8_ppgtt_alloc_page_directories
authorMichel Thierry <michel.thierry@intel.com>
Thu, 30 Apr 2015 15:06:51 +0000 (16:06 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 8 May 2015 11:03:30 +0000 (13:03 +0200)
commit4dd738e9cd791ebac2a009f09f1761e85e7f0805
tree8036cf2718b09559c27bc6ddcc62959a08394917
parent5e562f1dddfa3242cede5ec49888260a856a9da2
drm/i915: Fix 32b overflow check in gen8_ppgtt_alloc_page_directories

The patch 69876bed7e008f5fe01538a2d47c09f2862129d0: "drm/i915/gen8:
page directories rework allocation" added an overflow warning, but the
mask had an extra 0. Use less typo-prone option suggested by Dave
instead, to check for (start + length) >= 0x100000000ULL.

This check will be unnecessary after gen8_alloc_va_range handles more
than 4 PDPs (48b addressing).

v2: Really check for 32b overflow (Ville)

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Dave Gordon <david.s.gordon@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Michel Thierry <michel.thierry@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/i915_gem_gtt.c