]> git.karo-electronics.de Git - karo-tx-linux.git/commit
libahci: fix result_tf handling after an ATA PIO data-in command
authorTejun Heo <tj@kernel.org>
Fri, 15 Oct 2010 09:00:08 +0000 (11:00 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 22 Nov 2010 18:59:46 +0000 (10:59 -0800)
commit4fc910677fa95f03bd8431d21766ba9d7d967fa0
treed919059c0fe74dd148fbd8a6ea6532ea13f81f41
parent28feaa47bc4f21545dce9834d9c8f90481647c1a
libahci: fix result_tf handling after an ATA PIO data-in command

commit 6ad601955315b010a117306b994f2204fae85fdc upstream.

ATA devices don't send D2H Reg FIS after an successful ATA PIO data-in
command.  The host is supposed to take the TF and E_Status of the
preceding PIO Setup FIS.  Update ahci_qc_fill_rtf() such that it takes
TF + E_Status from PIO Setup FIS after a successful ATA PIO data-in
command.

Without this patch, result_tf for such a command is filled with the
content of the previous D2H Reg FIS which belongs to a previous
command, which can make the command incorrectly seen as failed.

* Patch updated to grab the whole TF + E_Status from PIO Setup FIS
  instead of just E_Status as suggested by Robert Hancock.

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Mark Lord <kernel@teksavvy.com>
Cc: Robert Hancock <hancockrwd@gmail.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/ata/ahci.h
drivers/ata/libahci.c