]> git.karo-electronics.de Git - linux-beck.git/commit
ARM: OMAP3: PM: remove superfluous calls to pwrdm_clear_all_prev_pwrst()
authorPaul Walmsley <paul@pwsan.com>
Mon, 30 Jan 2012 09:47:24 +0000 (02:47 -0700)
committerKevin Hilman <khilman@ti.com>
Mon, 5 Mar 2012 23:38:02 +0000 (15:38 -0800)
commit506c7d7931317813b3142f57d44bf113102a2a8f
tree7a50f9f30ef7429935a92e8a58c6cbbb66cb9bad
parent015f1e4297ad32f83251f3f4cee2389ce5516e9e
ARM: OMAP3: PM: remove superfluous calls to pwrdm_clear_all_prev_pwrst()

Remove some superfluous calls to pwrdm_clear_all_prev_pwrst().
pwrdm_pre_transition(), which appears a few lines after these calls,
invokes pwrdm_clear_all_prev_pwrst() on each powerdomain -- there's no
need to do it twice.

N.B.: some of us have observed that accesses to the previous
powerstate registers seem to be quite slow.  Although the writes
removed by this patch should be buffered by the write buffer, there is
a read to a PRM register immediately afterwards.  That will block the
OMAP3 MPU until all of those writes complete.  So this patch should
result in a minor performance improvement during idle entry.

Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Rajendra Nayak <rnayak@ti.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Tested-by: Tero Kristo <t-kristo@ti.com>
[khilman@ti.com: removed a couple more for OMAP4]
Tested-by: Kevin Hilman <khilman@ti.com>
Signed-off-by: Kevin Hilman <khilman@ti.com>
arch/arm/mach-omap2/omap-mpuss-lowpower.c
arch/arm/mach-omap2/pm34xx.c