]> git.karo-electronics.de Git - karo-tx-linux.git/commit
md/raid10: fix bug which causes all RAID10 reshapes to move no data.
authorNeilBrown <neilb@suse.de>
Thu, 4 Jul 2013 06:41:53 +0000 (16:41 +1000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Jul 2013 21:07:28 +0000 (14:07 -0700)
commit509c317d092a551f5c26de05445fc8d5b81cc23d
tree2631b7cfa7f8654adbe218efe71f7af2ced898be
parent3bd92a9d1f82e41d781f082d710b16036a0ea25b
md/raid10: fix bug which causes all RAID10 reshapes to move no data.

commit 1376512065b23f39d5f9a160948f313397dde972 upstream.

The recent comment:
commit 7e83ccbecd608b971f340e951c9e84cd0343002f
    md/raid10: Allow skipping recovery when clean arrays are assembled

Causes raid10 to skip a recovery in certain cases where it is safe to
do so.  Unfortunately it also causes a reshape to be skipped which is
never safe.  The result is that an attempt to reshape a RAID10 will
appear to complete instantly, but no data will have been moves so the
array will now contain garbage.
(If nothing is written, you can recovery by simple performing the
reverse reshape which will also complete instantly).

Bug was introduced in 3.10, so this is suitable for 3.10-stable.

Signed-off-by: NeilBrown <neilb@suse.de>
Cc: Martin Wilck <mwilck@arcor.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/md/raid10.c