]> git.karo-electronics.de Git - karo-tx-linux.git/commit
ARM: 7411/1: audit: fix treatment of saved ip register during syscall tracing
authorWill Deacon <will.deacon@arm.com>
Fri, 4 May 2012 16:52:02 +0000 (17:52 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 12 May 2012 16:32:09 +0000 (09:32 -0700)
commit50f764acf24996dc3fd845f837f88a80b80b7d53
tree875c34f0bf91360936cf78d3d652cf4f8e32aafa
parentacfee6ae4cf54e4afb10252c86dc72ca3472eec7
ARM: 7411/1: audit: fix treatment of saved ip register during syscall tracing

commit 6a68b6f574c8ad2c1d90f0db8fd95b8abe8a0a73 upstream.

The ARM audit code incorrectly uses the saved application ip register
value to infer syscall entry or exit. Additionally, the saved value will
be clobbered if the current task is not being traced, which can lead to
libc corruption if ip is live (apparently glibc uses it for the TLS
pointer).

This patch fixes the syscall tracing code so that the why parameter is
used to infer the syscall direction and the saved ip is only updated if
we know that we will be signalling a ptrace trap.

Reported-and-Tested-by: Jon Masters <jcm@jonmasters.org>
Cc: Eric Paris <eparis@redhat.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/arm/kernel/ptrace.c