]> git.karo-electronics.de Git - karo-tx-linux.git/commit
iwlwifi: fix skb usage after free
authorStanislaw Gruszka <sgruszka@redhat.com>
Wed, 20 Apr 2011 13:57:14 +0000 (15:57 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 9 May 2011 22:55:41 +0000 (15:55 -0700)
commit51028920a9424e2437d6acc3bbc0946d6d71a7aa
treefdf94fe0b9b3d001ed3dbda34022ef43495d0bba
parent49abf47d18ef1e3c67f3a29cd9eda03f48818652
iwlwifi: fix skb usage after free

commit b25026981aecde3685dd0e45ad980fff9f528daa upstream.

Since

commit a120e912eb51e347f36c71b60a1d13af74d30e83
Author: Stanislaw Gruszka <sgruszka@redhat.com>
Date:   Fri Feb 19 15:47:33 2010 -0800

    iwlwifi: sanity check before counting number of tfds can be free

we use skb->data after calling ieee80211_tx_status_irqsafe(), which
could free skb instantly.

On current kernels I do not observe practical problems related with
bug, but on 2.6.35.y it cause random system hangs when stressing
wireless link.

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Acked-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/net/wireless/iwlwifi/iwl-tx.c