]> git.karo-electronics.de Git - karo-tx-linux.git/commit
memory hotplug: suppress "Device nodeX does not have a release() function" warning
authorYasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Thu, 25 Oct 2012 01:14:47 +0000 (12:14 +1100)
committerStephen Rothwell <sfr@canb.auug.org.au>
Thu, 1 Nov 2012 04:24:03 +0000 (15:24 +1100)
commit51bd2f0d0237f75a10cc3bce7c3525c5ede8dd8e
treea1b78042c0556f05ee6f736d8ba4c4e1080bf232
parentf0c93cb1d1b758c7ea558416b4d2fbc17789c227
memory hotplug: suppress "Device nodeX does not have a release() function" warning

When calling unregister_node(), the function shows following message at
device_release().

"Device 'node2' does not have a release() function, it is broken and must
be fixed."

The reason is node's device struct does not have a release() function.

So the patch registers node_device_release() to the device's release()
function for suppressing the warning message.  Additionally, the patch
adds memset() to initialize a node struct into register_node().  Because
the node struct is part of node_devices[] array and it cannot be freed by
node_device_release().  So if system reuses the node struct, it has a
garbage.

Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
Acked-by: David Rientjes <rientjes@google.com>
Cc: Jiang Liu <liuj97@gmail.com>
Cc: Minchan Kim <minchan.kim@gmail.com>
Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
drivers/base/node.c