]> git.karo-electronics.de Git - karo-tx-linux.git/commit
execve: improve interactivity with large arguments
authorRoland McGrath <roland@redhat.com>
Wed, 8 Sep 2010 02:36:28 +0000 (19:36 -0700)
committerPaul Gortmaker <paul.gortmaker@windriver.com>
Thu, 6 Jan 2011 23:08:17 +0000 (18:08 -0500)
commit530cec0b21b6f8fdd2cd45893bb9c06b6afe256e
treeaa3ae6e6131deca81967baad7a68e0cc14b21e5c
parentfe3a036d4230f0268aec6409ec396b323c0b1f0e
execve: improve interactivity with large arguments

commit 7993bc1f4663c0db67bb8f0d98e6678145b387cd upstream.

This adds a preemption point during the copying of the argument and
environment strings for execve, in copy_strings().  There is already
a preemption point in the count() loop, so this doesn't add any new
points in the abstract sense.

When the total argument+environment strings are very large, the time
spent copying them can be much more than a normal user time slice.
So this change improves the interactivity of the rest of the system
when one process is doing an execve with very large arguments.

Signed-off-by: Roland McGrath <roland@redhat.com>
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
fs/exec.c