]> git.karo-electronics.de Git - karo-tx-linux.git/commit
nbd: clear waiting_queue on shutdown
authorPaul Clements <paul.clements@steeleye.com>
Mon, 17 Sep 2012 21:09:02 +0000 (14:09 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 2 Oct 2012 17:29:59 +0000 (10:29 -0700)
commit547ee164a63242ef14c41410615aa60aa164fce2
tree8cf97cd29fd887a7bf7f02353701b386cd61efe2
parent9fd0132a29b4e40e5cf5ff82a02227b7f603bba7
nbd: clear waiting_queue on shutdown

commit fded4e090c60100d709318896c79816d68d5b47d upstream.

Fix a serious but uncommon bug in nbd which occurs when there is heavy
I/O going to the nbd device while, at the same time, a failure (server,
network) or manual disconnect of the nbd connection occurs.

There is a small window between the time that the nbd_thread is stopped
and the socket is shutdown where requests can continue to be queued to
nbd's internal waiting_queue.  When this happens, those requests are
never completed or freed.

The fix is to clear the waiting_queue on shutdown of the nbd device, in
the same way that the nbd request queue (queue_head) is already being
cleared.

Signed-off-by: Paul Clements <paul.clements@steeleye.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/block/nbd.c