]> git.karo-electronics.de Git - mv-sheeva.git/commit
agp: Remove the BKL from agp_open
authorJohn Kacur <jkacur@redhat.com>
Sun, 11 Oct 2009 20:24:25 +0000 (22:24 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Wed, 14 Oct 2009 15:36:54 +0000 (17:36 +0200)
commit55e858c8483af427144f33b42b818b30612b82b0
tree300663182d53ca9ae77a54dce06066109e927a8f
parentf96d3015e9f7f7fff4cab7ed1d467664cc980061
agp: Remove the BKL from agp_open

- Remove the BKL from agp_open
- Perform a few clean-ups.

Analysis:
---------
int minor is local to the function.

The following are protected by agp_fe.agp_mutex
struct agp_file_private *priv;
struct agp_client *client;

Call-outs:

kzalloc should be safe to call under the mutex_lock

agp_find_client_by_pid:
- agp_mmap calls that under agp_fe.agp_mutex which we hold in agp_open
- agpioc_reserve_wrap calls it without any locking what-so-ever.
- Is that an error? Or is that okay because it has pid that is
  a unique handle?

agp_insert_file_private:
- This function only manipulates struct agp_file_private, once again
  while agp_fe.agp_mutex is held

Signed-off-by: John Kacur <jkacur@redhat.com>
Acked-by: David Airlie <airlied@linux.ie>
LKML-Reference: <alpine.LFD.2.00.0910112216060.12574@localhost.localdomain>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
drivers/char/agp/frontend.c