]> git.karo-electronics.de Git - linux-beck.git/commit
tty: Fix spurious poll() wakeups
authorPeter Hurley <peter@hurleysoftware.com>
Thu, 7 Aug 2014 11:14:10 +0000 (07:14 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 8 Sep 2014 22:55:25 +0000 (15:55 -0700)
commit57087d515441cab49ff02480aa40a09abfe02c78
tree79c4c9c407bb737a19fdbdcd1e76bb9da737ffab
parentb216df53848129c969a465bb9237fbc9b8fafaad
tty: Fix spurious poll() wakeups

When the N_TTY line discipline receives data and wakes readers to
process the input, polling writers are also mistakenly woken. This
is because, although readers and writers are differentiated by
different wait queues (tty->read_wait & tty->write_wait), both
wait queues are polled together. Thus, reader wakeups without poll
flags still cause poll(POLLOUT) to wakeup.

For received data, wakeup readers with POLLIN. Preserve the
unspecific wakeup in n_tty_packet_mode_flush(), as this action
should flag both POLLIN and POLLOUT.

Fixes epoll_wait() for edge-triggered EPOLLOUT.

Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/n_tty.c