]> git.karo-electronics.de Git - karo-tx-linux.git/commit
xen: correctly check for pending events when restoring irq flags
authorDavid Vrabel <david.vrabel@citrix.com>
Thu, 26 Apr 2012 18:44:06 +0000 (19:44 +0100)
committerBen Hutchings <ben@decadent.org.uk>
Fri, 11 May 2012 12:14:32 +0000 (13:14 +0100)
commit585bfaac76e8392e83e82b7457de2f326f29fded
tree2ed69a9cfb54b029f2075ab7776ae2f0b592b507
parent72f1409d18618284d29f22823270ad8c370911a0
xen: correctly check for pending events when restoring irq flags

commit 7eb7ce4d2e8991aff4ecb71a81949a907ca755ac upstream.

In xen_restore_fl_direct(), xen_force_evtchn_callback() was being
called even if no events were pending.  This resulted in (depending on
workload) about a 100 times as many xen_version hypercalls as
necessary.

Fix this by correcting the sense of the conditional jump.

This seems to give a significant performance benefit for some
workloads.

There is some subtle tricksy "..since the check here is trying to
check both pending and masked in a single cmpw, but I think this is
correct. It will call check_events now only when the combined
mask+pending word is 0x0001 (aka unmasked, pending)." (Ian)

Acked-by: Ian Campbell <ian.campbell@citrix.com>
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
arch/x86/xen/xen-asm.S