]> git.karo-electronics.de Git - karo-tx-linux.git/commit
e1000e: stop unnecessary polling when using msi-x
authorAndy Gospodarek <andy@greyhouse.net>
Thu, 18 Jun 2009 11:57:37 +0000 (11:57 +0000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 2 Jul 2009 23:49:38 +0000 (16:49 -0700)
commit587bea21b5959aa6a4771ec29b70b2e3cc72189d
tree4afa289c798e05ee1a0c1ee27604bb9b2953c5d1
parentdacbd10990bae0b514a0d0164c6206452d777742
e1000e: stop unnecessary polling when using msi-x

[ Upstream commit 679e8a0f0ae3333e94b1d374d07775fce9066025 ]

The last hunk of this commit:

    commit 12d04a3c12b420f23398b4d650127642469a60a6
    Author: Alexander Duyck <alexander.h.duyck@intel.com>
    Date:   Wed Mar 25 22:05:03 2009 +0000

        e1000e: commonize tx cleanup routine to match e1000 & igb

changed the logic for determining if we should call napi_complete or
not at then end of a napi poll.

If the NIC is using MSI-X with no work to do in ->poll, net_rx_action
can just spin indefinitely on older kernels and for 2 jiffies on newer
kernels since napi_complete is never called and budget isn't
decremented.

Discovered and verified while testing driver backport to an older
kernel.

Signed-off-by: Andy Gospodarek <andy@greyhouse.net>
Acked-by: Alexander Duyck <alexander.h.duyck@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/net/e1000e/netdev.c