]> git.karo-electronics.de Git - karo-tx-linux.git/commit
x86: ret_from_fork - get rid of jump back
authorIngo Molnar <mingo@elte.hu>
Thu, 27 Nov 2008 13:41:21 +0000 (14:41 +0100)
committerIngo Molnar <mingo@elte.hu>
Fri, 28 Nov 2008 14:01:46 +0000 (15:01 +0100)
commit5b3eec0c80038c8739ccd465b897a35c0dff1cc4
tree52a4625c34af62dc41233ecdf21e2d5262683e8f
parent3bdae4f46445ea7cc9ee031d7ff106fdc6228669
x86: ret_from_fork - get rid of jump back

Impact: remove dead code

If we take a closer look at the rff_trace/rff_action ret_from_fork code,
we have to realize that it does all the wrong things: for example it
checks the TIF flag - while later on jumping back to the ret-from-syscall
path - duplicating the check needlessly.

But checking for _TIF_SYSCALL_TRACE is completely unnecessary here because
we clear that flag for every freshly forked task. So the whole "tracing"
code here, for which there is a out of line jump optimization that makes
it even harder to read, is in reality completely dead code ...

Reported-by: Cyrill Gorcunov <gorcunov@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Tested-by: Cyrill Gorcunov <gorcunov@gmail.com>
arch/x86/kernel/entry_64.S