]> git.karo-electronics.de Git - karo-tx-linux.git/commit
NFSv4: Fix unnecessary delegation returns in nfs4_do_open
authorTrond Myklebust <Trond.Myklebust@netapp.com>
Fri, 8 Jun 2012 14:58:09 +0000 (10:58 -0400)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 19 Jun 2012 22:18:16 +0000 (23:18 +0100)
commit5b89f6bc01adb03d54dc90ecead12d86550fa6bb
treecdad8f26041cb50bedd755f869a2e235fe0f89b2
parent67c94967a36535a3e6c495ceda9b41aee2c448db
NFSv4: Fix unnecessary delegation returns in nfs4_do_open

commit 2d0dbc6ae8a5194aaecb9cfffb9053f38fce8b86 upstream.

While nfs4_do_open() expects the fmode argument to be restricted to
combinations of FMODE_READ and FMODE_WRITE, both nfs4_atomic_open()
and nfs4_proc_create will pass the nfs_open_context->mode,
which contains the full fmode_t.

This patch ensures that nfs4_do_open strips the other fmode_t bits,
fixing a problem in which the nfs4_do_open call would result in an
unnecessary delegation return.

Reported-by: Fred Isaman <iisaman@netapp.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
fs/nfs/nfs4proc.c