]> git.karo-electronics.de Git - karo-tx-linux.git/commit
igb: Fix Null-pointer dereference in igb_reset_q_vector
authorChristoph Paasch <christoph.paasch@uclouvain.be>
Fri, 21 Mar 2014 10:48:19 +0000 (03:48 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 7 Jun 2014 17:28:18 +0000 (10:28 -0700)
commit5c0f1fdbaebb742c0903bba402772f0db7760aa1
tree09d4a14b927e8e00f525d8f6b2f11d7d529148f3
parent8a255ad5da168d12278f6a59bb2727ca07416c9d
igb: Fix Null-pointer dereference in igb_reset_q_vector

commit cb06d102327eadcd1bdc480bfd9f8876251d1007 upstream.

When igb_set_interrupt_capability() calls
igb_reset_interrupt_capability() (e.g., because CONFIG_PCI_MSI is unset),
num_q_vectors has been set but no vector has yet been allocated.

igb_reset_interrupt_capability() will then call igb_reset_q_vector,
which assumes that the vector is allocated. As this is not the case, we
are accessing a NULL-pointer.

This patch fixes it by checking that q_vector is indeed different from
NULL.

Fixes: 02ef6e1d0b0023 (igb: Fix queue allocation method to accommodate changing during runtime)
Cc: Carolyn Wyborny <carolyn.wyborny@intel.com>
Signed-off-by: Christoph Paasch <christoph.paasch@uclouvain.be>
Tested-by: Jeff Pieper <jeffrey.e.pieper@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/intel/igb/igb_main.c