]> git.karo-electronics.de Git - karo-tx-linux.git/commit
thinkpad-acpi: fix LED blinking through timer trigger
authorHenrique de Moraes Holschuh <hmh@hmh.eng.br>
Fri, 24 Apr 2009 16:05:21 +0000 (16:05 +0000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 8 May 2009 22:44:58 +0000 (15:44 -0700)
commit5c47524b514b5bb3732c3b893338a210d67da3cd
tree1dccd92dbb40416d68b19582249390e2f452d871
parent60f9c3b02c5adfa2bfb1061642e5086df61d4d6a
thinkpad-acpi: fix LED blinking through timer trigger

upstream commit: 75bd3bf2ade9d548be0d2bde60b5ee0fdce0b127

The set_blink hook code in the LED subdriver would never manage to get
a LED to blink, and instead it would just turn it on.  The consequence
of this is that the "timer" trigger would not cause the LED to blink
if given default parameters.

This problem exists since 2.6.26-rc1.

To fix it, switch the deferred LED work handling to use the
thinkpad-acpi-specific LED status (off/on/blink) directly.

This also makes the code easier to read, and to extend later.

Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: stable@kernel.org
Signed-off-by: Len Brown <len.brown@intel.com>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
drivers/platform/x86/thinkpad_acpi.c