]> git.karo-electronics.de Git - karo-tx-linux.git/commit
dccp: handle invalid feature options length
authorDan Rosenberg <drosenberg@vsecurity.com>
Fri, 6 May 2011 03:27:18 +0000 (03:27 +0000)
committerPaul Gortmaker <paul.gortmaker@windriver.com>
Wed, 14 Mar 2012 14:57:54 +0000 (10:57 -0400)
commit5c6997e05926b59b5f7067077b7da41d5be99de3
tree5c3b826e4579f0809b056ff0a4867e66ed599b5f
parenta97b66db08803e16a8ae05f9f13736878045130c
dccp: handle invalid feature options length

commit a294865978b701e4d0d90135672749531b9a900d upstream.

A length of zero (after subtracting two for the type and len fields) for
the DCCPO_{CHANGE,CONFIRM}_{L,R} options will cause an underflow due to
the subtraction.  The subsequent code may read past the end of the
options value buffer when parsing.  I'm unsure of what the consequences
of this might be, but it's probably not good.

Signed-off-by: Dan Rosenberg <drosenberg@vsecurity.com>
Acked-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
net/dccp/options.c