]> git.karo-electronics.de Git - karo-tx-linux.git/commit
iwlwifi: don't mess up the SCD when removing a key
authorEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Wed, 6 Jun 2012 07:13:36 +0000 (09:13 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 17 Jun 2012 18:21:25 +0000 (11:21 -0700)
commit5ca732f5673f2a1fa9e4d6451259ae5891fa6b60
treeeb0f01e5784e3b03684523883f88fb7172128748
parent5a4c9cbfe943986db40b699c5320fdacfa2885b8
iwlwifi: don't mess up the SCD when removing a key

commit d6ee27eb13beab94056e0de52d81220058ca2297 upstream.

When we remove a key, we put a key index which was supposed
to tell the fw that we are actually removing the key. But
instead the fw took that index as a valid index and messed
up the SRAM of the device.

This memory corruption on the device mangled the data of
the SCD. The impact on the user is that SCD queue 2 got
stuck after having removed keys.
The message is the log that was printed is:

Queue 2 stuck for 10000ms

This doesn't seem to fix the higher queues that get stuck
from time to time.

Reviewed-by: Meenakshi Venkataraman <meenakshi.venkataraman@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/wireless/iwlwifi/iwl-agn-sta.c