]> git.karo-electronics.de Git - karo-tx-linux.git/commit
[media] snd_tea575x: Make the module using snd_tea575x the fops owner
authorHans de Goede <hdegoede@redhat.com>
Sat, 19 May 2012 10:57:03 +0000 (07:57 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Mon, 11 Jun 2012 19:02:54 +0000 (16:02 -0300)
commit5daf53a6eb5c54c618c9def388d81c2769fd11a0
treeae26108d5971c8e9fb7fcc5d9795b12145a1466b
parent0875eb755b66a6766be117133dbb6d8157ace337
[media] snd_tea575x: Make the module using snd_tea575x the fops owner

Before this patch the owner field of the /dev/radio# device fops was set to
the snd-tea575x-tuner module itself. Meaning that the module which was using
it could be rmmod-ed while the device is open, and then BAD things happen.

I know, as I found out the hard way :)

Note that there is no need to also somehow increase the refcount of the
snd-tea575x-tuner module itself, since any drivers using it will have
symbolic references to it.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
CC: Ondrej Zary <linux@rainbow-software.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/radio/radio-maxiradio.c
drivers/media/radio/radio-sf16fmr2.c
include/sound/tea575x-tuner.h
sound/i2c/other/tea575x-tuner.c
sound/pci/es1968.c
sound/pci/fm801.c