]> git.karo-electronics.de Git - karo-tx-linux.git/commit
i2c-smbus: Convert kzalloc to devm_kzalloc
authorJulia Lawall <Julia.Lawall@lip6.fr>
Mon, 10 Sep 2012 23:41:17 +0000 (09:41 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Mon, 10 Sep 2012 23:41:17 +0000 (09:41 +1000)
commit5e73b53ba1533d491b7072be0da96e5fe63acfb1
treee252e0cf864cb408c0077ab554a661fcd5aa1147
parente3ceb90218b6e821fe7490f4a155729acf8761b0
i2c-smbus: Convert kzalloc to devm_kzalloc

Converting kzalloc to devm_kzalloc simplifies the code and ensures that the
result, alert, is freed after the irq allocated by the subsequent
devm_request_irq.  This in turn ensures that when an interrupt can be
triggered, the alert structure is still available.

The problem of a free after a devm_request_irq was found using the
following semantic match (http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
expression e1,e2,x,a,b,c,d;
identifier free;
position p1,p2;
@@

  devm_request_irq@p1(e1,e2,...,x)
  ... when any
      when != e2 = a
      when != x = b
  if (...) {
    ... when != e2 = c
        when != x = d
    free@p2(...,x,...);
    ...
    return ...;
  }
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
drivers/i2c/i2c-smbus.c