]> git.karo-electronics.de Git - linux-beck.git/commit
[media] cx231xx: fix usbdev leak on failure paths in cx231xx_usb_probe()
authorAlexey Khoroshilov <khoroshilov@ispras.ru>
Fri, 16 Jan 2015 22:55:26 +0000 (19:55 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Mon, 2 Feb 2015 12:47:15 +0000 (10:47 -0200)
commit5eeb3014827f44ea7de43c865118cb2095ad030e
tree4939b10b67a62cd9b244c7642edd028bdc2c4c84
parente99f0115e56ce4c4cda269cd21b25f7e14fa548f
[media] cx231xx: fix usbdev leak on failure paths in cx231xx_usb_probe()

Commit b7085c086475 ("cx231xx: convert from pr_foo to dev_foo")
moves usb_get_dev(interface_to_usbdev(interface)) to the beginning
of cx231xx_usb_probe() to use udev->dev in dev_err(),
but it does not make sure usbdev is put on all failure paths.

Later dev_err(udev->dev) was replaced by dev_err(d).
So the patch moves usb_get_dev() below (before the first use)
and fixes another failure path.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/usb/cx231xx/cx231xx-cards.c