]> git.karo-electronics.de Git - karo-tx-linux.git/commit
Disable G5 NAP mode during SMU commands on U3
authorBenjamin Herrenschmidt <benh@kernel.crashing.org>
Thu, 7 Feb 2008 03:29:43 +0000 (14:29 +1100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 26 Feb 2008 00:18:48 +0000 (16:18 -0800)
commit5ef76ae0cc433e1e5927e964ad3320842ee94106
treee26eb15bf9c25521b7f2a8af299aa240b7223f47
parent58e6cf1df821c76f245a45da05f4ac8f880e3296
Disable G5 NAP mode during SMU commands on U3

patch 592a607bbc053bc6f614a0e619326009f4b3829e in mainline.

It appears that with the U3 northbridge, if the processor is in NAP
mode the whole time while waiting for an SMU command to complete,
then the SMU will fail.  It could be related to the weird backward
mechanism the SMU uses to get to system memory via i2c to the
northbridge that doesn't operate properly when the said bridge is
in napping along with the CPU.  That is on U3 at least, U4 doesn't
seem to be affected.

This didn't show before NO_HZ as the timer wakeup was enough to make
it work it seems, but that is no longer the case.

This fixes it by disabling NAP mode on those machines while
an SMU command is in flight.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Paul Mackerras <paulus@samba.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
arch/powerpc/platforms/powermac/feature.c
drivers/macintosh/smu.c
include/asm-powerpc/pmac_feature.h