]> git.karo-electronics.de Git - linux-beck.git/commit
[SCSI] libfc: fix statistics for FCP input/output megabytes
authorJoe Eykholt <jeykholt@cisco.com>
Wed, 1 Dec 2010 00:20:18 +0000 (16:20 -0800)
committerJames Bottomley <James.Bottomley@suse.de>
Tue, 21 Dec 2010 18:24:34 +0000 (12:24 -0600)
commit5f0e385fdafb7d6c8ded6464fa6421c735d96caf
treef589124e9cf33dc10deb6084456e68245f6dbea5
parentba9cd5d095b42271588c20ccd6ddd561d0e4cc1e
[SCSI] libfc: fix statistics for FCP input/output megabytes

The statistics for InputMegabytes and OutputMegabytes are
misnamed.  They're accumulating bytes, not megabytes.

The statistic returned via /sys must be in megabytes, however,
which is what the HBA-API wants.  The FCP code needs to accumulate
it in bytes and then divide by 1,000,000 (not 2^20) before it
presented via sysfs.

This affects fcoe.ko only, not fnic.  The fnic driver
correctly by accumulating bytes and then converts to megabytes.

I checked that libhbalinux is using the /sys file directly without
conversion.

BTW, qla2xxx does divide by 2^20, which I'm not fixing here.

Signed-off-by: Joe Eykholt <jeykholt@cisco.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
drivers/scsi/libfc/fc_fcp.c
drivers/scsi/libfc/fc_lport.c
include/scsi/libfc.h