]> git.karo-electronics.de Git - karo-tx-linux.git/commit
rtc: mxc: Initialize drvdata before registering device
authorWolfram Sang <w.sang@pengutronix.de>
Wed, 4 May 2011 15:31:27 +0000 (17:31 +0200)
committerJohn Stultz <john.stultz@linaro.org>
Sat, 7 May 2011 00:40:10 +0000 (17:40 -0700)
commit5f54c8a00af20e5cf38c3e5ef2f59b6848a17cd9
tree3fd5d20a1581314cfefe788bc5e9e74d57e1be3b
parent5895198c56d131cc696556a45f7ff0ea99ac297b
rtc: mxc: Initialize drvdata before registering device

Commit f44f7f96a20 ("RTC: Initialize kernel state from RTC") uncovered
an issue in a number of RTC drivers, where the drivers call
rtc_device_register before initializing the device or platform drvdata.

This frequently results in null pointer dereferences when the
rtc_device_register immediately makes use of the rtc device, calling
rtc_read_alarm.

The solution is to ensure the drvdata is initialized prior to registering
the rtc device.

CC: Alessandro Zummo <a.zummo@towertech.it>
CC: Thomas Gleixner <tglx@linutronix.de>
CC: rtc-linux@googlegroups.com
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
[fixed up commit log -jstultz]
Signed-off-by: John Stultz <john.stultz@linaro.org>
drivers/rtc/rtc-mxc.c