]> git.karo-electronics.de Git - karo-tx-linux.git/commit
Currently in oprofilefs, files that use ulong_fops mis-handle writes of
authorMike Waychison <mikew@google.com>
Wed, 24 Aug 2011 23:47:38 +0000 (09:47 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Fri, 9 Sep 2011 06:16:22 +0000 (16:16 +1000)
commit5fbd19732ebcea4189cbfb258511c6fa4cf28dd2
treef1b80128d49032ef5285d8491c60d296e356cbfc
parenteba17394c00f4c6b7d8272e5e6cfdfa0970a758c
Currently in oprofilefs, files that use ulong_fops mis-handle writes of
zero length.  A count of 0 causes oprofilefs_ulong_from_user to return 0
(success), which then leads to oprofile_set_ulong being called to stuff
"value" into file->private_data without it being initialized.

Fix this by moving the check for a zero-length write up into
ulong_write_file.

Signed-off-by: Mike Waychison <mikew@google.com>
Cc: Robert Richter <robert.richter@amd.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
drivers/oprofile/oprofilefs.c