]> git.karo-electronics.de Git - karo-tx-linux.git/commit
lib-vsprintf-optimize-put_dec_trunc8-fix
authorGeorge Spelvin <linux@horizon.com>
Wed, 26 Sep 2012 01:34:17 +0000 (11:34 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Thu, 27 Sep 2012 07:27:37 +0000 (17:27 +1000)
commit613f59f0fd3128cd1e3ac0baa8c90198896815ca
treed802191e5c25c4c8095b8d8f35c096ef24613960
parentfe3e1d8cca8bb3162e0324491feeedc7fa5c97e9
lib-vsprintf-optimize-put_dec_trunc8-fix

Rabin Vincent <rabin@rab.in> wrote:
> This patch breaks IP address printing with "%pI4" (and by extension,
> nfsroot).  Example:
>
>  - Before: 10.0.0.1
>  - After: 10...1

Mea culpa, and thank you for catching it!  As I said in my earlier
comment, I tested this most extensively wrapped by some sprintf code
that liked 0 converted to a 0-length string, as that works naturally
with the ANSI spec for %.0u.  And it turns out not to matter for the
usual printf code, as num_to_str special-cases that anyway.

The fix is straightforward:

Signed-off-by: George Spelvin <linux@horizon.com>
Cc: Rabin Vincent <rabin@rab.in>
Cc: Denys Vlasenko <vda.linux@googlemail.com>
Cc: Michal Nazarewicz <mina86@mina86.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
lib/vsprintf.c