]> git.karo-electronics.de Git - karo-tx-linux.git/commit
libceph: call r_unsafe_callback when unsafe reply is received
authorYan, Zheng <zheng.z.yan@intel.com>
Mon, 24 Jun 2013 06:41:27 +0000 (14:41 +0800)
committerSage Weil <sage@inktank.com>
Wed, 3 Jul 2013 22:32:58 +0000 (15:32 -0700)
commit61c5d6bf7074ee32d014dcdf7698dc8c59eb712d
tree803e65fbc0ab446ad891cf6494fd6cc5ae3fa2a5
parent6ee6b95373dfa1d0a4c9bc76689ec10a60c1d6f2
libceph: call r_unsafe_callback when unsafe reply is received

We can't use !req->r_sent to check if OSD request is sent for the
first time, this is because __cancel_request() zeros req->r_sent
when OSD map changes. Rather than adding a new variable to struct
ceph_osd_request to indicate if it's sent for the first time, We
can call the unsafe callback only when unsafe OSD reply is received.
If OSD's first reply is safe, just skip calling the unsafe callback.

The purpose of unsafe callback is adding unsafe request to a list,
so that fsync(2) can wait for the safe reply. fsync(2) doesn't need
to wait for a write(2) that hasn't returned yet. So it's OK to add
request to the unsafe list when the first OSD reply is received.
(ceph_sync_write() returns after receiving the first OSD reply)

Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>
Reviewed-by: Sage Weil <sage@inktank.com>
net/ceph/osd_client.c