]> git.karo-electronics.de Git - karo-tx-linux.git/commit
USB: mos7840: fix race in led handling
authorJohan Hovold <jhovold@gmail.com>
Fri, 26 Jul 2013 09:55:19 +0000 (11:55 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 12 Aug 2013 01:35:21 +0000 (18:35 -0700)
commit62a2cfc242dd948a1edfe46681f553276a48cc7f
treef29f2606217fcd70b78e85c52b50bfb8e6d5495f
parented183fba4ecbc327570cd0655916cebaae918dcd
USB: mos7840: fix race in led handling

commit 05cf0dec5ccc696a7636c84b265b477173498156 upstream.

Fix race in LED handling introduced by commit 0eafe4de ("USB: serial:
mos7840: add support for MCS7810 devices") which reused the port control
urb for manipulating the LED without making sure that the urb is not
already in use. This could lead to the control urb being manipulated
while in flight.

Fix by adding a dedicated LED urb and ctrlrequest along with a LED-busy
flag to handle concurrency.

Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/serial/mos7840.c