]> git.karo-electronics.de Git - karo-tx-linux.git/commit
xen: handle events as edge-triggered
authorJeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Sat, 21 Aug 2010 02:10:01 +0000 (19:10 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 20 Sep 2010 20:36:05 +0000 (13:36 -0700)
commit62b1700a2d04d5a5a8a506b7c604be9bd0b5ca79
tree17a2eef036ff879a5c1c8e4154cdf7f01899496b
parent4427834682c11181af9627b99beabbe38f0830be
xen: handle events as edge-triggered

commit dffe2e1e1a1ddb566a76266136c312801c66dcf7 upstream.

Xen events are logically edge triggered, as Xen only calls the event
upcall when an event is newly set, but not continuously as it remains set.
As a result, use handle_edge_irq rather than handle_level_irq.

This has the important side-effect of fixing a long-standing bug of
events getting lost if:
 - an event's interrupt handler is running
 - the event is migrated to a different vcpu
 - the event is re-triggered

The most noticable symptom of these lost events is occasional lockups
of blkfront.

Many thanks to Tom Kopec and Daniel Stodden in tracking this down.

Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Cc: Tom Kopec <tek@acm.org>
Cc: Daniel Stodden <daniel.stodden@citrix.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/xen/events.c