]> git.karo-electronics.de Git - karo-tx-linux.git/commit
powerpc 4xx EMAC driver: device name reported on timeout is not correct
authorMikhail Zolotaryov <lebon@lebon.org.ua>
Thu, 19 Mar 2009 22:28:02 +0000 (22:28 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sat, 21 Mar 2009 23:50:20 +0000 (16:50 -0700)
commit62f0c338d126fee75dc04bd23be30281a0e1e62f
treebbb314e4e9a107dfc3e2172970e4fdd29b9a1015
parented734a97c6a81b644bd648afd7a337deb0ccd7e5
powerpc 4xx EMAC driver: device name reported on timeout is not correct

Hi,

IBM EMAC driver performs device reset (drivers/net/ibm_newemac/core.c:
emac_probe() -> emac_init_phy() -> emac_reset()) before registering
appropriate net_device (emac_probe() -> register_netdev()), so
net_device name contains raw format string during EMAC reset ("eth%d").

If the case of reset timeout, emac_report_timeout_error() function is
called to report an error. The problem is this function uses net_device
name to report device related, which is not correct, as a result in the
kernel log buffer we see:

eth%d: reset timeout

The solution is to print device_node full_name instead. After applying
the patch proposed, error string is like the following:

/plb/opb/ethernet@ef600e00: reset timeout

Signed-off-by: Mikhail Zolotaryov <lebon@lebon.org.ua>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ibm_newemac/core.c