]> git.karo-electronics.de Git - karo-tx-linux.git/commit
davinci_mdio: Fix MDIO timeout check
authorChristian Riesch <christian.riesch@omicron.at>
Mon, 16 Apr 2012 04:35:25 +0000 (04:35 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 27 Apr 2012 17:16:36 +0000 (10:16 -0700)
commit63441881b73b7a609a4bb098cfc760f5996bef55
treeaf2477b3ca559a6ee61704ed4b4fc3ad4df7bfec
parent75473dbe96f24d632f41164058794b62413fa3f2
davinci_mdio: Fix MDIO timeout check

commit 5b76d0600b2b08eef77f8e9226938b7b6bde3099 upstream.

Under heavy load (flood ping) it is possible for the MDIO timeout to
expire before the loop checks the GO bit again. This patch adds an
additional check whether the operation was done before actually
returning -ETIMEDOUT.

To reproduce this bug, flood ping the device, e.g., ping -f -l 1000
After some time, a "timed out waiting for user access" warning
may appear. And even worse, link may go down since the PHY reported a
timeout.

Signed-off-by: Christian Riesch <christian.riesch@omicron.at>
Cc: Cyril Chemparathy <cyril@ti.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/ti/davinci_mdio.c