]> git.karo-electronics.de Git - linux-beck.git/commit
mmc: sdhci: Setting the host->mrq to NULL before executing tuning
authorChuansheng Liu <chuansheng.liu@intel.com>
Tue, 5 Nov 2013 06:52:45 +0000 (14:52 +0800)
committerChris Ball <chris@printf.net>
Mon, 13 Jan 2014 17:48:13 +0000 (12:48 -0500)
commit63c211803a272d59dcb11af82ad0364b3d1d2a2e
tree5c0884f4ded5994df5a09501a3ec4be7058b1f3e
parent00411135474264ce74310d2a7f7017885dd41545
mmc: sdhci: Setting the host->mrq to NULL before executing tuning

In function sdhci_request(), it is possible to do the tuning execution
like below:

sdhci_request() {
spin_lock_irqsave(&host->lock, flags);
host->mrq = mrq;
...
spin_unlock_irqrestore(&host->lock, flags);

<=== Here it is possible one pending finish_tasklet get running
     and it will operate the original mrq, and notified the mrq
     is done, and causes memory corruption.

sdhci_execute_tuning(mmc, tuning_opcode);
spin_lock_irqsave(&host->lock, flags);
host->mrq = mrq;
...
}

In the above race place, the original mrq should not be finished wrongly,
so here before unlock the spinlock, we need to set the host->mrq to NULL
to avoid this case.

Signed-off-by: Liu, Chuansheng <chuansheng.liu@intel.com>
Signed-off-by: Chris Ball <cjb@laptop.org>
drivers/mmc/host/sdhci.c