]> git.karo-electronics.de Git - karo-tx-linux.git/commit
Currently in oprofilefs, files that use ulong_fops mis-handle writes of
authorMike Waychison <mikew@google.com>
Wed, 24 Aug 2011 23:47:38 +0000 (09:47 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Mon, 12 Sep 2011 05:27:31 +0000 (15:27 +1000)
commit63d749e6cff4c15885be9b00ee895ef5f1bea818
treec755d103fc8d37685d55dd91235a81a24797df09
parent6be7a573b79a3c7805320d00181b2a2c262921d4
Currently in oprofilefs, files that use ulong_fops mis-handle writes of
zero length.  A count of 0 causes oprofilefs_ulong_from_user to return 0
(success), which then leads to oprofile_set_ulong being called to stuff
"value" into file->private_data without it being initialized.

Fix this by moving the check for a zero-length write up into
ulong_write_file.

Signed-off-by: Mike Waychison <mikew@google.com>
Cc: Robert Richter <robert.richter@amd.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
drivers/oprofile/oprofilefs.c