]> git.karo-electronics.de Git - linux-beck.git/commit
NFS: Fix /proc/fs/nfsfs/servers and /proc/fs/nfsfs/volumes
authorEric W. Biederman <ebiederm@xmission.com>
Thu, 31 Jul 2014 11:35:20 +0000 (04:35 -0700)
committerEric W. Biederman <ebiederm@xmission.com>
Mon, 4 Aug 2014 16:28:32 +0000 (09:28 -0700)
commit65b38851a17472d31fec9019fc3a55b0802dab88
tree4b5830300b5cbd722f5b1680b96aaa5e72c0d638
parentdb181ce011e3c033328608299cd6fac06ea50130
NFS: Fix /proc/fs/nfsfs/servers and /proc/fs/nfsfs/volumes

The usage of pid_ns->child_reaper->nsproxy->net_ns in
nfs_server_list_open and nfs_client_list_open is not safe.

/proc for a pid namespace can remain mounted after the all of the
process in that pid namespace have exited.  There are also times
before the initial process in a pid namespace has started or after the
initial process in a pid namespace has exited where
pid_ns->child_reaper can be NULL or stale.  Making the idiom
pid_ns->child_reaper->nsproxy a double whammy of problems.

Luckily all that needs to happen is to move /proc/fs/nfsfs/servers and
/proc/fs/nfsfs/volumes under /proc/net to /proc/net/nfsfs/servers and
/proc/net/nfsfs/volumes and add a symlink from the original location,
and to use seq_open_net as it has been designed.

Cc: stable@vger.kernel.org
Cc: Trond Myklebust <trond.myklebust@primarydata.com>
Cc: Stanislav Kinsbursky <skinsbursky@parallels.com>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
fs/nfs/client.c
fs/nfs/inode.c
fs/nfs/internal.h
fs/nfs/netns.h