]> git.karo-electronics.de Git - karo-tx-linux.git/commit
net: Fix call to ->change_rx_flags(dev, IFF_MULTICAST) in dev_change_flags()
authorDavid Woodhouse <dwmw2@infradead.org>
Tue, 20 May 2008 21:36:14 +0000 (14:36 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 16 Jun 2008 20:19:55 +0000 (13:19 -0700)
commit6600b220d4e12ec47b4ffc710840c98940c1bb8e
tree0de9bb44b6bc9b91698a071f0167c1ce579bd985
parent5c1c9ddc6d50656beef56b03cf87510f1a01e5ef
net: Fix call to ->change_rx_flags(dev, IFF_MULTICAST) in dev_change_flags()

[ upstream commit: 0e91796eb46e29edc791131c832a2232bcaed9dd ]

Am I just being particularly dim today, or can the call to
dev->change_rx_flags(dev, IFF_MULTICAST) in dev_change_flags() never
happen?

We've just set dev->flags = flags & IFF_MULTICAST, effectively. So the
condition '(dev->flags ^ flags) & IFF_MULTICAST' is _never_ going to be
true.

Signed-off-by: David Woodhouse <dwmw2@infradead.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
net/core/dev.c