]> git.karo-electronics.de Git - karo-tx-linux.git/commit
Yama: access task_struct->comm directly
authorKees Cook <keescook@chromium.org>
Wed, 15 Aug 2012 18:41:55 +0000 (11:41 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 26 Aug 2012 02:31:41 +0000 (19:31 -0700)
commit67dd44b1ec0de935b8ad962e00ee8da44d67fc28
tree483e7dbc36db4036b756f84d48a34c1e1bf4af20
parent2069c08ae4d4c75582b7ed2ddd60fc3c32dfde15
Yama: access task_struct->comm directly

commit 7612bfeecc197bbb6629842b5c6ff1967f0a9b70 upstream.

The core ptrace access checking routine holds a task lock, and when
reporting a failure, Yama takes a separate task lock. To avoid a
potential deadlock with two ptracers taking the opposite locks, do not
use get_task_comm() and just use ->comm directly since accuracy is not
important for the report.

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Suggested-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Acked-by: John Johansen <john.johansen@canonical.com>
Signed-off-by: James Morris <james.l.morris@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
security/yama/yama_lsm.c